-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Markdown] [Web/API] Suppress GFM conversion of wide (>150 character) tables #8736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
sideshowbarker
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7898.
This PR adds a new class
"no-markdown"
to all tables under Web/API that:The
"no-markdown"
class stops the converter from converting these tables to GFM.The reasoning is that GFM tables are hard to read when they get above a certain width, and discussion in #7898 (comment) landed on 150 characters as a reasonable threshold.
Once conversion is done, we should probably remove the
"no-markdown"
class, as it serves no further purpose.Note that this PR also removes
"standard-table"
from tables in all files it touches. This has no effect (standard-table
is a no-op since mdn/mdn-minimalist#681).