-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-add Note: prefix #8238
Auto-add Note: prefix #8238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two cases of <em>
/</em>
enclosing the full note to remove, else evrerything is fine.
@@ -79,7 +79,7 @@ <h3 id="Values">Values</h3> | |||
</ul> | |||
|
|||
<div class="note"> | |||
<p><em>The <code>KeyboardEventInit</code> dictionary also accepts fields from | |||
<p><strong>Note:</strong> <em>The <code>KeyboardEventInit</code> dictionary also accepts fields from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <em>
/ </em>
doesn't match our style guide. Can you fix it?
@@ -141,7 +141,7 @@ <h3 id="Values">Values</h3> | |||
client fields will throw a <code>TypeError</code>.</p> | |||
|
|||
<div class="note"> | |||
<p><em>The <code>MouseEventInit</code> dictionary also accepts fields from | |||
<p><strong>Note:</strong> <em>The <code>MouseEventInit</code> dictionary also accepts fields from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here <em>
s to remove
Thanks! Those should be fixed. |
This is part of #8180.
At this point almost all the remaining unconvertible notes are just missing the
<strong>Note:</strong>
prefix. This auto-adds it.In some cases this would not make sense, for example if the note is like
<p>Note that ...</p>
, we don't want:<p><strong>Note:</strong> Note that ...</p>
. So I've excluded these from this PR and will take care of them in a follow-up, along with any other stragglers.