Improve initial what is js example#42629
Merged
Conversation
github-actions
bot
added
Content:Learn
Contributor
|
Preview URLs Flaws (1)URL:
|
estelle
requested review from
a team and
pepelsbey
and removed request for
a team and
estelle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The initial What is JavaScript? article in the Learn area has an initial example that could be improved — two of the stages of the example use screenshots, while the third uses a live example.
This PR changes it so that all stages use live examples, removes the unneeded screenshots, and improves the language (I've removed the reference to MDN Playground, as currently the example doesn't work in the Playground, because it doesn't respect the sandbox settings set in the live sample macro.
I'll submit a separate issue for that— already being explored in mdn/fred#1073).Motivation
Additional details
Related issues and pull requests