Use descriptive canvas id in basic example #42510
Closed
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouni-Sanaboyina
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <canvas id="canvas"></canvas> | ||
| <canvas id="drawingCanvas"></canvas> | ||
| ``` | ||
| Use a descriptive ID to make it clear what the canvas element is used for. |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| Use a descriptive ID to make it clear what the canvas element is used for. | |
| Use a descriptive ID to make it clear what the canvas element is used for. |
|
|
||
| The actual drawing is done using the {{domxref("CanvasRenderingContext2D")}} interface. The {{domxref("CanvasRenderingContext2D.fillStyle", "fillStyle")}} property makes the rectangle green. The {{domxref("CanvasRenderingContext2D.fillRect()", "fillRect()")}} method places its top-left corner at (10, 10), and gives it a size of 150 units wide by 100 tall. | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
Member
|
Duplicate of #42159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Canvas API basic example to use a more descriptive canvas element ID, improving clarity and readability for beginners.
Motivation
Using a generic ID like
canvasis not a best practice. A descriptive ID makes the example easier to understand and aligns with recommended coding conventions in documentation.Additional details
N/A
Related issues and pull requests
Fixes #42155