Enhance documentation for 'object-fit' CSS property #42014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a note on the importance of setting
widthandheightfor effectiveobject-fitapplication.Description
I added a note about how to use the
object-fitproperty effectivelyMotivation
object-fitproperty doesn't work on my personal examples, I did what the docs instruct, but that property fails to apply. And just later I discovered that I should set a height and width to the image in order for thatobject-fitto be applied effectively. I think that works the same for all the replaced-elements, but I only tested it forimgelements.object-fiteffectively.Additional details
There is no clue or note about that even in the object-fit mdn-reference
Related issues and pull requests