Skip to content

Fix content issues #41351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Fix content issues #41351

merged 1 commit into from
Oct 1, 2025

Conversation

Josh-Cena
Copy link
Member

In the spirit of #41350, I'm fixing all other cases where we use a variable before defining it, even when it's not technically a bug. However it's not possible to catch all cases, such as the one #41350 is reporting about, because it's not a live sample so we don't have the full code.

@Josh-Cena Josh-Cena requested review from a team as code owners September 30, 2025 17:19
@Josh-Cena Josh-Cena requested review from fred-wang, sideshowbarker, estelle and bsmth and removed request for a team September 30, 2025 17:19
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs Content:wasm WebAssembly docs Content:MathML MathML docs system [PR only] Infrastructure and configuration for the project labels Sep 30, 2025
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Sep 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (48 pages)
Flaws (8)

Note! 43 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Extensions/Client-side_APIs/Drawing_graphics
Title: Drawing graphics
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/examples/web-animations/cat_sprite.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/API/Element/wheel_event
Title: Element: wheel event
Flaw count: 3

  • macros:
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDelta
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDeltaX
    • Can't resolve /en-US/docs/Web/API/WheelEvent/wheelDeltaY

URL: /en-US/docs/Web/API/HTMLButtonElement/reportValidity
Title: HTMLButtonElement: reportValidity() method
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect

URL: /en-US/docs/Web/API/HTMLInputElement/reportValidity
Title: HTMLInputElement: reportValidity() method
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect

URL: /en-US/docs/Web/MathML/Tutorials/For_beginners/Fractions_and_roots
Title: MathML fractions and roots
Flaw count: 2

  • unknown:
    • Error serializing baseline for numeric-seperators: missing field description``
    • Error serializing baseline for single-color-gradients: missing field description``
External URLs (8)

URL: /en-US/docs/Learn_web_development/Core/Structuring_content/Debugging_HTML
Title: Debugging HTML

URL: /en-US/docs/Learn_web_development/Extensions/Server-side/First_steps/Web_frameworks
Title: Server-side web frameworks

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element: innerHTML property

URL: /en-US/docs/Web/API/SpeechRecognition
Title: SpeechRecognition

URL: /en-US/docs/Web/API/SpeechRecognition/start
Title: SpeechRecognition: start() method

URL: /en-US/docs/Web/API/Web_Speech_API/Using_the_Web_Speech_API
Title: Using the Web Speech API

URL: /en-US/docs/WebAssembly/Guides/Rust_to_Wasm
Title: Compiling from Rust to WebAssembly

bsmth
bsmth approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks 👍🏻

@Josh-Cena Josh-Cena merged commit 6ba4f3b into mdn:main Oct 1, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-content branch October 1, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:wasm WebAssembly docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The example/demo of the article has a bug Weekly spelling check
2 participants
@Josh-Cena @bsmth