Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added formal syntax to gradient functions #13646

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Added formal syntax to gradient functions #13646

merged 1 commit into from
Mar 8, 2022

Conversation

NiedziolkaMichal
Copy link
Member

Summary

I added links to Formal Syntax in all gradient functions. I see that they are present in data\css\syntaxes.json so I think it should work.

repeating-linear-gradient and repeating-radial-gradient currently have formal syntax hardcoded in content file, but its style is incorrect and links are broken. I replaced them with formal syntax macro too.

Motivation

Supporting details

Related issues

Issue #13194

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@NiedziolkaMichal NiedziolkaMichal requested a review from a team as a code owner March 8, 2022 12:26
@NiedziolkaMichal NiedziolkaMichal requested review from ericwbailey and removed request for a team March 8, 2022 12:26
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/gradient/linear-gradient()
Title: linear-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/radial-gradient()
Title: radial-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()
Title: repeating-radial-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/conic-gradient()
Title: conic-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-linear-gradient()
Title: repeating-linear-gradient()
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/gradient/repeating-conic-gradient()
Title: repeating-conic-gradient()
on GitHub

No new external URLs

@NiedziolkaMichal
Copy link
Member Author

I see that repeating-conic-gradient is missing in data. I will add it in separate PR.

@NiedziolkaMichal
Copy link
Member Author

I defined repeating-conic-gradient formal syntax in #571

teoli2003
teoli2003 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1

@teoli2003 teoli2003 merged commit 5a69fa4 into mdn:main Mar 8, 2022
@NiedziolkaMichal NiedziolkaMichal deleted the gradient-formal-syntax branch March 8, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiedziolkaMichal @teoli2003