Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Mocha to test test/utils.js #6857

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Introduce Mocha to test test/utils.js #6857

merged 1 commit into from
Nov 3, 2020

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Oct 7, 2020 •
edited
Loading

Also enable colors in GitHub Actions for nicer logs.

Fixes #6855.

@github-actions github-actions bot added dependencies Pull requests that update a dependency package or file. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. labels Oct 7, 2020
@foolip foolip mentioned this pull request Oct 7, 2020
Closed
@ddbeck ddbeck added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Oct 15, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 15, 2020

Blocked by #5931 or, more concretely, merging master-scoped-package into master. See also #6640.

@ddbeck ddbeck mentioned this pull request Oct 15, 2020
Closed
@foolip foolip marked this pull request as ready for review October 30, 2020 20:52
@foolip foolip requested a review from ddbeck as a code owner October 30, 2020 20:52
@foolip foolip removed the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Oct 30, 2020
@foolip
Copy link
Contributor Author

foolip commented Oct 30, 2020

This is now ready for review.

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 2, 2020

@foolip I'm done wrecking package-lock.json for the day. I suspect this will be a quick merge, after a rebase.

@foolip
Introduce Mocha to test test/utils.js
7fc6e69 
Also enable colors in GitHub Actions for nicer logs.

Fixes mdn#6855.
@foolip
Copy link
Contributor Author

foolip commented Nov 2, 2020 •
edited
Loading

@ddbeck this is rebased and passing on GitHub Actions now.

ddbeck
ddbeck approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you—excited to do more with this! 🎉

@ddbeck ddbeck merged commit e02d8ce into mdn:master Nov 3, 2020
@foolip foolip deleted the mocha branch November 3, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency package or file. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a test framework
2 participants
@foolip @ddbeck