-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Node.js ≥10 for CI and drop Travis #6797
Conversation
We'll also need to update the readme to include a new build status badge, since it's currently connected to Travis CI. I found one here: https://actions-badge.atrox.dev/ [![Build Status](https://img.shields.io/endpoint.svg?url=https%3A%2F%2Factions-badge.atrox.dev%2Fmdn%2Fbrowser-compat-data%2Fbadge&style=flat)](https://actions-badge.atrox.dev/mdn/browser-compat-data/goto) (Alternatively, we can just remove the badge altogether. Personally, I enjoy having a badge of the build status on the readme, since it tells me "there's no issues in our code so you can expect it to function properly", but I'm not strong on this.) |
If there's no first party badge support for GitHub Actions then just not having one seems fine too. Maybe it's just me, but I've never found a badge like that useful when looking at someone else's repository or for my own. |
I have personally also never found build-status badges useful at all in repo READMEs, so I’d also vote for not considering it a loss if we don’t have one. |
I went ahead and dropped all the badges. I'm also a member of team doesn't-care-about-badges, but I thought there was a case for removing each one individually:
|
This concludes the `mdn-` package name and continues development under the `@mdn/browser-compat-data` name. * Implement 2.0.0 breaking changes (#6713) * Rename package and increment version to pre-2.0 * Require Node 10 or later * Rename package in the docs * Increment prerelease version * Initial release of @mdn/browser-compat-data A continuation of mdn/browser-compat-data * Patch release containing data or non-breaking updates only * Revert "Add mdn- and Node.js 8 deprecation warnings for 1.1 release (#6777)" This applies only to the 1.1.x releases. This reverts commit ee7feac. * Patch release containing data or non-breaking updates only * Patch release containing data or non-breaking updates only * Use Node.js ≥10 for CI and drop Travis (#6797) * Use Node.js ≥10 for CI * Remove Travis CI config * Remove badges from README * Patch release containing data or non-breaking updates only
This upgrades the GitHub Actions workflows to use Node.js 10 and later (10 for publishing releases, 10 and 14 for tests). It also removes the config for Travis CI.
Note that this PR applies to the
master-scoped-package
branch; it won't affect work onmaster
until after we end BCD 1.x-series releases (and consequently mergemaster-scoped-branch
intomaster
).This is a step toward #5931, but it doesn't completely resolve it.