Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2.0.0 breaking changes #6713

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 17, 2020

This is one of several ugly steps to carry out #6640.

This PR does two key things:

An additional ugly thing I'm going to do is a pre-release from this branch (i.e., ddbeck-2.0-breaking-changes) before merging to demonstrate that, well, it works as a new package. This will also test the new packaging workflow before I release BCD 1.0.38 today.

@ddbeck ddbeck requested a review from Elchi3 as a code owner September 17, 2020 10:49
@github-actions github-actions bot added dependencies Pull requests that update a dependency package or file. docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project schema Isses or pull requests regarding the JSON schema files used in this project. labels Sep 17, 2020
@ddbeck
Copy link
Collaborator Author

ddbeck commented Sep 17, 2020

OK, we now have a pre-release of @mdn/browser-compat-data so you can actually try this out. In the process, I got the new publishing workflow working and I can do the next mdn- release.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

package.json Show resolved Hide resolved
docs/contributing.md Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge then.

@ddbeck ddbeck force-pushed the ddbeck-2.0-breaking-changes branch from 191a578 to 5a9858c Compare September 23, 2020 14:20
@ddbeck
Copy link
Collaborator Author

ddbeck commented Sep 23, 2020

Thank you, @chrisdavidmills!

I have since updated the base branch from master and rebased. Merging this now.

@ddbeck ddbeck merged commit 38c32f9 into master-scoped-package Sep 23, 2020
@ddbeck ddbeck deleted the ddbeck-2.0-breaking-changes branch September 23, 2020 15:23
ddbeck added a commit that referenced this pull request Oct 29, 2020
This concludes the `mdn-` package name and continues development under the `@mdn/browser-compat-data` name.

* Implement 2.0.0 breaking changes (#6713)

* Rename package and increment version to pre-2.0
* Require Node 10 or later
* Rename package in the docs
* Increment prerelease version

* Initial release of @mdn/browser-compat-data

A continuation of mdn/browser-compat-data

* Patch release containing data or non-breaking updates only

* Revert "Add mdn- and Node.js 8 deprecation warnings for 1.1 release (#6777)"

This applies only to the 1.1.x releases.

This reverts commit ee7feac.

* Patch release containing data or non-breaking updates only

* Patch release containing data or non-breaking updates only

* Use Node.js ≥10 for CI and drop Travis (#6797)

* Use Node.js ≥10 for CI
* Remove Travis CI config
* Remove badges from README

* Patch release containing data or non-breaking updates only
@Elchi3 Elchi3 removed their request for review December 17, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency package or file. docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants