Node 24 adds several Locale.get*() methods#28708
Merged
Conversation
github-actions
bot
added
data:js
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
RiskyMH
reviewed
Dec 19, 2025
github-actions
bot
added
size:s
caugner
force-pushed
the
28703-locale-in-node-removed-minimalDays
branch
from
758fdcf to
0199c54
Compare
github-actions
bot
added
size:xs
github-actions
bot
added
size:l
caugner
changed the title
minimalDays from Locale.getWeekInfo()Locale.get*() methods
Elchi3
approved these changes
Jan 9, 2026
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
This is all analog to Chrome/v8, so LGTM.
Thanks Claas! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node 24.0.0 adds several
Locale.get*()methods (in addition to the accessor properties).Also: Node 24.0.0 removed
minimalDaysfrom the object returned byLocale.getWeekInfo().Test results and supporting details
The
minimalDaysproperty is no longer mentioned in the spec.The change was part of bumping V8 to 13.6, which made it into Node 24.0.0.
Related issues
Fixes #28703.