-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the support for align-content with multicol layouts #22757
Merged
queengooborg
merged 9 commits into
mdn:main
from
CodeRedDigital:32662-enable-align-content
Jun 20, 2024
Merged
added the support for align-content with multicol layouts #22757
queengooborg
merged 9 commits into
mdn:main
from
CodeRedDigital:32662-enable-align-content
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:css
Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
label
Apr 2, 2024
This was referenced Apr 2, 2024
teoli2003
pushed a commit
to mdn/data
that referenced
this pull request
Apr 4, 2024
### Description Updated appliesTo field for CSS property `align-content` ### Motivation Working on [Issue 32662](mdn/content#32662) ### Related issues and pull requests - [Content PR](mdn/content#32862) - [Firefox release note PR](mdn/content#32863) - [BCD PR](mdn/browser-compat-data#22702) - [Second BCD PR](mdn/browser-compat-data#22757)
queengooborg
requested changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have a hierarchy issue -- the grid_context
layout was mistakenly moved inside of the flex_context
feature, and the new multicol_context
was also placed there. They should be siblings of flex_context
instead.
queengooborg
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the support for multicol layouts
Test results and supporting details
Tested in Chrome, Edge, Safari & Firefox. All support this except Firefox
Related issues