Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the support for align-content with multicol layouts #22757

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Apr 2, 2024

Summary

Added the support for multicol layouts

Test results and supporting details

Tested in Chrome, Edge, Safari & Firefox. All support this except Firefox

Related issues

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Apr 2, 2024
teoli2003 pushed a commit to mdn/data that referenced this pull request Apr 4, 2024
### Description

Updated appliesTo field for CSS property `align-content`

### Motivation

Working on [Issue 32662](mdn/content#32662)

### Related issues and pull requests

- [Content PR](mdn/content#32862)
- [Firefox release note PR](mdn/content#32863)
- [BCD PR](mdn/browser-compat-data#22702)
- [Second BCD PR](mdn/browser-compat-data#22757)
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have a hierarchy issue -- the grid_context layout was mistakenly moved inside of the flex_context feature, and the new multicol_context was also placed there. They should be siblings of flex_context instead.

@dletorey dletorey requested a review from queengooborg June 19, 2024 13:31
@queengooborg queengooborg merged commit d88fd98 into mdn:main Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants