-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control if metrics or traces are sent to collector #98
base: main
Are you sure you want to change the base?
Conversation
Before starting the review of this PR, I'd like to put the demos back (elastic, jaeger, etc) to work. I followed the instructions in the readme without success 🤔 |
Are the issues with the demo related to this PR? I don't think I broke anything. It's fine if they are not, just wanting clarity. |
No no, not related at all. Sorry for the confusion. I added that to express that we are adding code with the demos being broken. |
In between some tasks, I will go through each of the demos and adjust them. |
I'm on PTO until the new year, so will go back to this right after that. Thank you so much for your work 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'm missing a test for this, probably because the current state of the code does not allow it.
Can we add a TODO comment, or simply better opening an issue?, so that we can refactor the initialisation of the otel providers and eventually write tests about that?
OR, if you find it testable, e.g. adding multiple instances of the |
i will see about generalizing things about. |
We currently only want to send metrics to our OTEL Collector. I'm seeing errors about not being able to send traces because the collector doesn't have tracing configured.
This PR adds a flags that allow us to turn off the sending of traces (or metrics if that is your thing).