-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --properties-allowed switch and retries to test. #89
Added --properties-allowed switch and retries to test. #89
Conversation
Let's rebase and resolve conflicts first 🙏 |
0557e74
to
ea12e9c
Compare
I've rebased and resolved conflicts. This was the branch that originally included the retry changes. Are you wanting those removed? |
I think the branch still has conflicts, probably gotten from the retry, so yeah, let's remove them by now, as they sleep was not needed anymore with the wait.ForFile strategy in the tests |
main_test.go
Outdated
if len(jsons) != 2 { | ||
t.Errorf("expected 2 JSONs, got %d - %s", len(jsons), jsons) | ||
var jsons []string | ||
err = retry.Do(func() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the wait strategy do its job here.
The conflicts are from the PR that was merged after I resolved the conflicts from the earlier merge. The test is much faster without the 30s wait. I will resolve the conflicts in the morning. |
I tried it without the retry and I randomly get:
|
I've resolved the merge conflicts and am switching the port retry to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is part of reducing cardinality. The JUnit XML from Ginkgo and gotestsum contains arbitrary properties we don't want pushed to our metrics system.