-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 target to all projects, upgrade driver project to VS2022 and latest WDK for x64 and ARM64 build + minor corrections (typos) + Upgrading to latest VS2022 toolset for all projects #52
base: master
Are you sure you want to change the base?
Conversation
24e42d3
to
35315bf
Compare
Hi Travis, this seems to be a nice feature to add for libusbK. Please help to review when you got some time. Thanks. |
44d1229
to
390c42e
Compare
Great! Thanks for the contribution. I will ask if I can sign this with my work certificate. |
Is the addition of the .inf file intentional? It was not mentioned in the commit message. |
This file was generated by the KDMF template project, and is used by the last step when building the project to create a nice inf + car + sys folder ready to use for testing or for production given the correct signing key was specified in the project properties. I am sure we could do without it but I thought it was a convenient way to have a example / template inf file that people could directly complete with their VID/PID and produce a driver package. |
Thanks. Yes it seems interesting and useful, that's why I got curious about it. That it was generated from the project data answers my question. |
390c42e
to
50c2070
Compare
As of now the projects files may not be totally correct for ARM64 build. Example: ARM64 build --> libusbK.sys is for ARM64 but not for other projects.
|
x64 build is good.
x86 build is good as well. |
@TravisRo and @sonatique Another thing, this PR is based on VS2022 and latest WDK. As per Peter (@dontech), we can not support Windows 7/8 with this build. Reference discussion: |
@mcuee : regarding build: yes, indeed, ARM64 is only for libusbK.sys for now, I can try to add ARM64 for everything if there is interest for it. If maintaining everything in one code base becomes too difficult, we can fork to another project for "Win10" libusbK, or maintain a distinct branch alongside master. I can also remove the toolset upgrade from this commit, but I thought that moving away from VS2019 would make sens. |
Yes, please help to update. Thanks. |
I am okay with upgrading to VS2022 and Windows 11 WDK (now Windows 11 WDK version 22H2), and drop support for Windows 7/8/8.1. But let's hear the opinion of Travis. @TravisRo
One option is to have two separate folders: but maybe this is too much work. Again let's hear the opinion of Travis. @TravisRo
Reference: |
…d latest WDK for x64 and ARM64 build + minor corrections (typos) + Upgrading to latest VS2022 toolset for all projects
50c2070
to
23c6527
Compare
Done |
Please take a look at this PR when you get some time. Thanks. |
Any updates on this topic? It is indeed good to be able to sign the driver file (even for the current git master). |
@TravisRo |
With this upgrade I was able to build libusbK.sys from ARM64 easily. Ongoing test on Windows ARM seems to indicate everything is working seamlessly
Note: support for building with makefile is sill there, but I did not upgrade it for building for ARM64.
Building libusbK.sys for ARM64 / X64 is now directly done from within Visual Studio (current libusbK.sys project is only there for convenience when editing files, the actual build process is based on makefile