Skip to content

test(e2e 614): ask mcpp where its store is, do not guess - #578

Merged
Sunrisepeak merged 1 commit into
mainfrom
fix/614-asks-instead-of-guessing
Sep 6, 2026
Merged

test(e2e 614): ask mcpp where its store is, do not guess#578
Sunrisepeak merged 1 commit into
mainfrom
fix/614-asks-instead-of-guessing

Conversation

@Sunrisepeak

Copy link
Copy Markdown
Member

What

e2e 614 derived the payload store from ${MCPP_HOME:-$HOME/.mcpp} while the
binary under test resolves its home from its own location — a released mcpp
carries a registry/ beside itself.

Pointed at the released 2026.9.6.2 tarball the test therefore failed about
features while really measuring a path mismatch
.

Why it is worth a commit rather than a note

The same guess cost a CI job in llama.cpp-m on the same day: its Vulkan job
searched ${HOME}/.mcpp for the lavapipe ICD while the payloads sat under
$RUNNER_TEMP. One fact, two readers, both guessing.

The fix

mcpp index status names a path under the home the binary actually uses. The
environment default remains the fallback for a build that has no index yet.

Measured

binary before after
locally built 2026.9.6.2 pass pass
released 2026.9.6.2 tarball fail pass
the binary predating the engine fix 614 exists for fail fail

The last row is the one that matters: the test still says no to what it was
written to catch.

The store was derived from `${MCPP_HOME:-$HOME/.mcpp}` while the BINARY under
test resolves its home from its own location: a released mcpp carries a
`registry/` beside itself. Pointed at a released tarball the test failed about
features while really measuring a path mismatch.

The same guess cost a CI job in llama.cpp-m on the same day, which is why this
is worth a commit rather than a note: it is one fact with two readers, and both
were guessing.

`mcpp index status` names a path under the home the binary actually uses, and
the environment default remains the fallback for a build that has no index yet.

Measured: passes against the locally built binary and against the released
2026.9.6.2 tarball, and still exits 1 against the binary predating the engine
fix it exists for.
@Sunrisepeak
Sunrisepeak merged commit 6c00d45 into main Sep 6, 2026
36 checks passed
@Sunrisepeak
Sunrisepeak deleted the fix/614-asks-instead-of-guessing branch September 6, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants