Enhance documentation and some fixes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds transient props notation where necessary to prevent non HTML props from leaking to the DOM.
The `animate` prop of the spinner component was previously named as `disableAnimation`, and probably during rename, its logic wasn't inverted. So this commit adjusts the logic and animate has the correct and expected behavior.
Ensures that the button has accessibility tags by indicating the label tag in stacked layout via `aria-labelledBy` attribute. Additionaly, corrects a malformed css style that caused the stacked layout button to render its icons out of place when `helperOnClick` prop is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add license reference in package-lock
docs: correct command to build
docs: add further documentation about custom styles
fix: main file entry point path
fix: prevent props leaking to DOM
fix(spinner): wrong prop logic
fix(BBButton): ensure acessibility and stacked layout displacement
Closes #2
Closes #3