Skip to content

Commit

Permalink
Merge pull request #756 from frankemax/755-feedback
Browse files Browse the repository at this point in the history
feat(feedback): add new options
  • Loading branch information
frankemax authored Apr 22, 2024
2 parents 8af0447 + da0662f commit a056926
Show file tree
Hide file tree
Showing 7 changed files with 138 additions and 87 deletions.
80 changes: 58 additions & 22 deletions src/screens/feedback-screen/customFeedback.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,12 @@
},
{
"textLabel":{
"id": "app.customFeedback.problem.whiteboard"
"id": "app.customFeedback.problem.interface"
},
"type": "radio",
"next": "whiteboardProblem",
"next": "interfaceProblem",
"key": "feedback.problem",
"value": "whiteboard"
"value": "interface"
},
{
"textLabel":{
Expand Down Expand Up @@ -177,7 +177,7 @@
},
{
"textLabel":{
"id": "app.customFeedback.cameraProblem.badQuality"
"id": "app.customFeedback.cameraProblem.imageQuality"
},
"type": "radio",
"next": "email",
Expand Down Expand Up @@ -221,7 +221,7 @@
},
{
"textLabel":{
"id": "app.customFeedback.connectionProblem.dataConsumption"
"id": "app.customFeedback.connectionProblem.data"
},
"type": "radio",
"next": "email",
Expand Down Expand Up @@ -256,7 +256,7 @@
},
{
"textLabel":{
"id": "app.customFeedback.microphoneProblem.deviceIdentification"
"id": "app.customFeedback.microphoneProblem.deviceidentification"
},
"type": "radio",
"next": "email",
Expand All @@ -283,38 +283,38 @@
}
]
},
"whiteboardProblem": {
"interfaceProblem": {
"titleLabel":{
"id": "app.customFeedback.whiteboardProblem.title"
"id": "app.customFeedback.interfaceProblem.title"
},
"progress": "2/2",
"options":[
{
"textLabel":{
"id": "app.customFeedback.whiteboardProblem.eraseTool"
"id": "app.customFeedback.interfaceProblem.loginUi"
},
"type": "radio",
"next": "email",
"key": "feedback.problem_detailed",
"value": "erasertool"
"value": "loginUi"
},
{
"textLabel":{
"id": "app.customFeedback.whiteboardProblem.bucketTool"
"id": "app.customFeedback.interfaceProblem.pollUi"
},
"type": "radio",
"next": "email",
"key": "feedback.problem_detailed",
"value": "buckettool"
"value": "pollUi"
},
{
"textLabel":{
"id": "app.customFeedback.whiteboardProblem.textEdition"
"id": "app.customFeedback.interfaceProblem.status"
},
"type": "radio",
"next": "email",
"key": "feedback.problem_detailed",
"value": "textedition"
"value": "status"
},
{
"textLabel":{
Expand All @@ -333,6 +333,33 @@
},
"progress": "1/2",
"options":[
{
"textLabel":{
"id": "app.customFeedback.like.notificationApp"
},
"type": "radio",
"next": "wish",
"key": "feedback.like",
"value": "notificationApp"
},
{
"textLabel":{
"id": "app.customFeedback.like.chatUx"
},
"type": "radio",
"next": "wish",
"key": "feedback.like",
"value": "chatUx"
},
{
"textLabel":{
"id": "app.customFeedback.like.appUi"
},
"type": "radio",
"next": "wish",
"key": "feedback.like",
"value": "appUi"
},
{
"textLabel":{
"id": "app.customFeedback.other"
Expand All @@ -352,39 +379,48 @@
"options":[
{
"textLabel":{
"id": "app.customFeedback.wish.moreUsers"
"id": "app.customFeedback.wish.backCamera"
},
"type": "radio",
"next": "email",
"key": "feedback.wish",
"value": "backCamera"
},
{
"textLabel":{
"id": "app.customFeedback.wish.whiteboardUse"
},
"type": "radio",
"next": "email",
"key": "feedback.wish",
"value": "moreusers"
"value": "whiteboardUse"
},
{
"textLabel":{
"id": "app.customFeedback.wish.chatInteracions"
"id": "app.customFeedback.wish.picture"
},
"type": "radio",
"next": "email",
"key": "feedback.wish",
"value": "chatinteractions"
"value": "picture"
},
{
"textLabel":{
"id": "app.customFeedback.wish.whiteboardTools"
"id": "app.customFeedback.wish.outputDevice"
},
"type": "radio",
"next": "email",
"key": "feedback.wish",
"value": "whiteboardtools"
"value": "outputDevice"
},
{
"textLabel":{
"id": "app.customFeedback.wish.accessibilityTools"
"id": "app.customFeedback.wish.privateChat"
},
"type": "radio",
"next": "email",
"key": "feedback.wish",
"value": "accessibilityTools"
"value": "privateChat"
},
{
"textLabel":{
Expand Down
5 changes: 4 additions & 1 deletion src/screens/feedback-screen/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, {
useCallback, useEffect, useRef, useState
} from 'react';
import { nativeApplicationVersion, nativeBuildVersion } from 'expo-application';
import { useFocusEffect, useNavigation } from '@react-navigation/native';
import { PORTRAIT, OrientationLocker } from 'react-native-orientation-locker';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -149,7 +150,9 @@ const FeedbackScreen = () => {
platformApiLevel,
productName,
suppCpuArch: supportedCpuArchitectures,
totalMemory
totalMemory,
appVersion: nativeApplicationVersion,
appBuildNumber: parseInt(nativeBuildVersion, 10) || 0,
},
},
user: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const ProblemFeedbackScreen = ({ route }) => {
if (value === true) {
answer.like = key;
if (key === 'other') {
answer.like_described = stepDetalied.text;
answer.like_described = stepDetalied;
}
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const SpecificProblemFeedbackScreen = ({ route }) => {
if (value === true) {
answer.wish = key;
if (key === 'other') {
answer.wish_described = stepDetalied.text;
answer.wish_described = stepDetalied;
}
}
});
Expand Down
55 changes: 28 additions & 27 deletions src/utils/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,43 +4,44 @@
"app.audioNotificaion.reconnectingAsListenOnly": "Microphone has been locked for viewers, you are being connected as listen only",
"app.chat.clearPublicChatMessage": "The public chat history was cleared by a moderator",
"app.chat.submitLabel": "Send message",
"app.content.presentation":"Presentation",
"app.content.screenshare":"Screenshare",
"app.content.presentation": "Presentation",
"app.content.screenshare": "Screenshare",
"app.customFeedback.defaultButtons.next": "Next",
"app.customFeedback.defaultButtons.skip": "Skip",
"app.customFeedback.email.contact": "Would you like to leave your email for contact?",
"app.customFeedback.email.placeholder": "Email (optional)",
"app.customFeedback.email.thank": "Thanks for your answers.",
"app.customFeedback.other": "Other:",
"app.customFeedback.like.title": "What did you like the most?",
"app.customFeedback.like.interactiveWhiteboard": "The interactive whiteboard",
"app.customFeedback.like.multimediaSharing": "Multimedia sharing (youtube...)",
"app.customFeedback.like.audioCaptions": "Captions",
"app.customFeedback.like.notificationApp": "Push notifications on the phone's notification bar",
"app.customFeedback.like.chatUx": "The chat",
"app.customFeedback.like.appUi": "New interface",
"app.customFeedback.wish.title": "What would you like to see?",
"app.customFeedback.wish.moreUsers": "More users per room",
"app.customFeedback.wish.chatInteracions": "More chat interaction (reactions, sending files, pasting images...)",
"app.customFeedback.wish.whiteboardTools": "More tools on the whiteboard (text editor, bucket tool...)",
"app.customFeedback.wish.accessibilityTools": "More accessibility tools",
"app.customFeedback.wish.backCamera": "Switch to back camera",
"app.customFeedback.wish.whiteboardUse": "Interact via whiteboard",
"app.customFeedback.wish.picture": "Picture-in-Picture",
"app.customFeedback.wish.outputDevice": "Modify output device",
"app.customFeedback.wish.privateChat": "Private chat",
"app.customFeedback.problem.audio": "Audio",
"app.customFeedback.problem.camera": "Video",
"app.customFeedback.problem.connection": "Internet Connection",
"app.customFeedback.problem.camera": "Camera",
"app.customFeedback.problem.connection": "Internet connection",
"app.customFeedback.problem.microphone": "Microphone",
"app.customFeedback.problem.whiteboard": "WhiteBoard",
"app.customFeedback.audioProblem.soundQuality": "Sound quality (noise, instability or volume)",
"app.customFeedback.audioProblem.hearOthers": "I can't listen to the other participants",
"app.customFeedback.audioProblem.audioSync": "The audio is out of sync with the participants' video",
"app.customFeedback.cameraProblem.activation": "My camera doesn't turn on",
"app.customFeedback.cameraProblem.seeOthers": "I can't see the other participants",
"app.customFeedback.cameraProblem.badQuality": "The image quality is bad",
"app.customFeedback.connectionProblem.instability": "I and/or other participants frequently lose connection",
"app.customFeedback.connectionProblem.freeze": "My internet is good and it still crashed a lot",
"app.customFeedback.connectionProblem.dataConsumption": "Consumed a lot of data from my connection",
"app.customFeedback.problem.interface": "Interface",
"app.customFeedback.audioProblem.soundQuality": "Sound quality (noise, instability, or volume)",
"app.customFeedback.audioProblem.hearOthers": "I can't hear other participants",
"app.customFeedback.audioProblem.audioSync": "The audio is out of sync with participants' video",
"app.customFeedback.cameraProblem.activation": "My camera won't turn on",
"app.customFeedback.cameraProblem.seeOthers": "I can't see other participants",
"app.customFeedback.cameraProblem.imageQuality": "The image quality is poor",
"app.customFeedback.connectionProblem.instability": "Myself and/or other participants frequently drop out",
"app.customFeedback.connectionProblem.freeze": "My internet connection is good, yet it still freezes a lot",
"app.customFeedback.connectionProblem.data": "It consumed a lot of my connection's data",
"app.customFeedback.microphoneProblem.activation": "I can't activate my microphone in the room",
"app.customFeedback.microphoneProblem.deviceIdentification": "My device wasn't recognized and I was muted",
"app.customFeedback.microphoneProblem.deviceidentification": "It didn't recognize my device and I was muted",
"app.customFeedback.microphoneProblem.echo": "Participants complained about echo",
"app.customFeedback.whiteboardProblem.eraseTool": "I would like an eraser",
"app.customFeedback.whiteboardProblem.bucketTool": "I would like the bucket tool to paint the shapes",
"app.customFeedback.whiteboardProblem.textEdition": "I would like to edit the texts I typed",
"app.customFeedback.interfaceProblem.loginUi": "Login screen",
"app.customFeedback.interfaceProblem.pollUi": "I had difficulty finding the poll",
"app.customFeedback.interfaceProblem.status": "I would like to change my status",
"app.error.400": "Bad Request",
"app.error.401": "Unauthorized",
"app.error.403": "You have been removed from the meeting",
Expand Down Expand Up @@ -213,7 +214,7 @@
"mobileSdk.poll.createPoll.responseOptions": "Response Options",
"mobileSdk.poll.createPoll.anonymousPoll": "Anonymous Poll.",
"mobileSdk.poll.createPoll.anonymousPollSubtitle": "You will not be able to view individual user responses.",
"app.poll.userResponse.label" : "Typed Response",
"app.poll.userResponse.label": "Typed Response",
"app.actionsBar.actionsDropdown.desktopShareLabel": "Share your screen",
"app.actionsBar.actionsDropdown.streamOptions": "Broadcast session",
"mobileSdk.notImplemented.modal.title": "Feature not implemented",
Expand All @@ -232,4 +233,4 @@
"mobileSdk.transfer.subtitle": "The session you are trying to access is full.",
"mobileSdk.transfer.subtitle2": "The moderator defined that new participants should be directed to the transfer room.",
"mobileSdk.transfer.button.title": "Join"
}
}
43 changes: 22 additions & 21 deletions src/utils/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,35 +12,36 @@
"app.customFeedback.email.placeholder": "Correo electrónico (opcional)",
"app.customFeedback.email.thank": "Gracias por tus respuestas.",
"app.customFeedback.other": "Otro:",
"app.customFeedback.like.title": "¿Qué te gustó más?",
"app.customFeedback.like.interactiveWhiteboard": "La pizarra interactiva",
"app.customFeedback.like.multimediaSharing": "Compartir multimedia (YouTube...)",
"app.customFeedback.like.audioCaptions": "Subtítulos de audio",
"app.customFeedback.like.title": "¿Qué fue lo que más te gustó?",
"app.customFeedback.like.notificationApp": "Notificaciones push en la barra de notificaciones del teléfono",
"app.customFeedback.like.chatUx": "El chat",
"app.customFeedback.like.appUi": "Nueva interfaz",
"app.customFeedback.wish.title": "¿Qué te gustaría ver?",
"app.customFeedback.wish.moreUsers": "Más usuarios por sala",
"app.customFeedback.wish.chatInteracions": "Más interacción en el chat (reacciones, envío de archivos, pegar imágenes...)",
"app.customFeedback.wish.whiteboardTools": "Más herramientas en la pizarra (editor de texto, herramienta de cubo...)",
"app.customFeedback.wish.accessibilityTools": "Más herramientas de accesibilidad",
"app.customFeedback.wish.backCamera": "Cambiar a cámara trasera",
"app.customFeedback.wish.whiteboardUse": "Interactuar mediante pizarra blanca",
"app.customFeedback.wish.picture": "Picture in Picture",
"app.customFeedback.wish.outputDevice": "Modificar dispositivo de salida",
"app.customFeedback.wish.privateChat": "Chat privado",
"app.customFeedback.problem.audio": "Audio",
"app.customFeedback.problem.camera": "Cámara",
"app.customFeedback.problem.connection": "Conexión a internet",
"app.customFeedback.problem.microphone": "Micrófono",
"app.customFeedback.problem.whiteboard": "Pizarra blanca",
"app.customFeedback.audioProblem.soundQuality": "Calidad del sonido (ruidos, inestabilidad o volumen)",
"app.customFeedback.audioProblem.hearOthers": "No puedo escuchar a los otros participantes",
"app.customFeedback.problem.interface": "Interfaz",
"app.customFeedback.audioProblem.soundQuality": "Calidad del sonido (ruido, inestabilidad o volumen)",
"app.customFeedback.audioProblem.hearOthers": "No puedo escuchar a otros participantes",
"app.customFeedback.audioProblem.audioSync": "El audio está fuera de sincronización con el vídeo de los participantes",
"app.customFeedback.cameraProblem.activation": "Mi cámara no se enciende",
"app.customFeedback.cameraProblem.seeOthers": "No puedo ver a los otros participantes",
"app.customFeedback.cameraProblem.badQuality": "La calidad de la imagen es mala",
"app.customFeedback.connectionProblem.instability": "Yo y/o otros participantes nos desconectamos con frecuencia",
"app.customFeedback.connectionProblem.freeze": "Mi internet es buena y aún así se congela mucho",
"app.customFeedback.connectionProblem.dataConsumption": "Consumió muchos datos de mi conexión",
"app.customFeedback.cameraProblem.seeOthers": "No puedo ver a otros participantes",
"app.customFeedback.cameraProblem.imageQuality": "La calidad de la imagen es baja",
"app.customFeedback.connectionProblem.instability": "Tanto yo como otros participantes nos desconectamos con frecuencia",
"app.customFeedback.connectionProblem.freeze": "Mi conexión a internet es buena y aún así se congela mucho",
"app.customFeedback.connectionProblem.data": "Consumió muchos datos de mi conexión",
"app.customFeedback.microphoneProblem.activation": "No puedo activar mi micrófono en la sala",
"app.customFeedback.microphoneProblem.deviceIdentification": "No reconoció mi dispositivo y me quedé en silencio",
"app.customFeedback.microphoneProblem.deviceidentification": "No reconoció mi dispositivo y quedé en silencio",
"app.customFeedback.microphoneProblem.echo": "Los participantes se quejaron de eco",
"app.customFeedback.whiteboardProblem.eraseTool": "Me gustaría tener una goma para borrar",
"app.customFeedback.whiteboardProblem.bucketTool": "Me gustaría tener un cubo de pintura para rellenar las formas",
"app.customFeedback.whiteboardProblem.textEdition": "Me gustaría editar los textos que he escrito",
"app.customFeedback.interfaceProblem.loginUi": "Pantalla de inicio de sesión",
"app.customFeedback.interfaceProblem.pollUi": "Tuve dificultades para encontrar la encuesta",
"app.customFeedback.interfaceProblem.status": "Me gustaría cambiar mi estado",
"app.error.400": "Solicitud incorrecta",
"app.error.401": "No autorizado",
"app.error.403": "Usted ha sido expulsado/a de la reunión",
Expand Down Expand Up @@ -230,4 +231,4 @@
"mobileSdk.transfer.subtitle": "La sesión a la que intentas acceder está llena.",
"mobileSdk.transfer.subtitle2": "El moderador definió que los nuevos participantes deben ser dirigidos a la sala de transferencia.",
"mobileSdk.transfer.button.title": "Entrar"
}
}
Loading

0 comments on commit a056926

Please sign in to comment.