Implement subscription filter option #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Sep 13, 2019
| filter: function (path, message, options) { | ||
| return true | ||
| } | ||
| }) |
Owner
There was a problem hiding this comment.
Can you add a test where the filter function return false? Also, you'll need to add some assertions on path, message and options.
Author
There was a problem hiding this comment.
If the filter function returns false the test times out b/c the message doesn't arrive. I'm not sure how to assert this. I will add assertions for three params as soon as I got some time.
Owner
There was a problem hiding this comment.
Just create a different experiment where you do not call pubSubTest, but rather write actual tests for things. Also, it will require a test for promise form of the async function.
* Update to @hapi/nes 12.x and @hapi/hapi 19.x * Update dependencies and switch tests to @hapi/lab and @hapi/code * Update CI to Node 12 (Hapi requirement)
mcollina
reviewed
Apr 3, 2020
package.json
Outdated
| { | ||
| "name": "multines", | ||
| "version": "1.0.0", | ||
| "version": "2.0.1", |
mcollina
reviewed
Apr 4, 2020
| { | ||
| "name": "multines", | ||
| "version": "1.0.0", | ||
| "version": "2.0.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the first try on an implementation. It works fine in my project but I need to test if the params and credentials arguments are properly working first. I've added these to stay as compatible with nes as possible. I'm not sure how to test the filter option properly though.
Submitting the pr so you can take a look and give feedback in case would like to do something different or have other suggestions.