Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spec coverage and fix string bug #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpotts244
Copy link

@jpotts244 jpotts244 commented Oct 23, 2018

In this PR

Link to original Issue here

  • Fix bug in the create method if no snapshot_name is passed in as an argument.
    Calling present? on an empty string returns runtime error:
# Failure/Error: if snapshot_name.present?
#
#     NoMethodError:
#       undefined method `present?' for "":String
#       Did you mean?  prepend
  • Added some specs to expose the bug and additional test coverage for other methods.

I have a question! I would like to write some more tests but it looks like when the Mongoid class is called in the test suite or in the dev console we are getting an uninitialized constant Db::Snapshot::Mongoid error, any thoughts on resolving this either locally or otherwise?

Thanks so much! and let me know if you have any feedback or ideas 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant