Skip to content

Updated codebase to use QuestDB instead of streaming files from S3#2

Merged
mccaffers merged 6 commits into
mainfrom
1-refactor-to-make-use-of-questdb-instead-of-tick-csv-files
Nov 30, 2025
Merged

Updated codebase to use QuestDB instead of streaming files from S3#2
mccaffers merged 6 commits into
mainfrom
1-refactor-to-make-use-of-questdb-instead-of-tick-csv-files

Updating CodeQL build and removing comments

ab03dad
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 30, 2025 in 25s

Quality Gate failed

Failed conditions
2 Security Hotspots
33.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 37 in src/backtesting/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this field 'private' and encapsulate it in a 'public' property.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb1Xpy6CQU_U116k&open=AZqHAb1Xpy6CQU_U116k&pullRequest=2

Check warning on line 3 in src/Models/BacktestingVariables.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare types in namespaces

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb5Mpy6CQU_U118R&open=AZqHAb5Mpy6CQU_U118R&pullRequest=2

Check failure on line 97 in tests/backtesting/EnvironmentVariableTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove or correct this assertion.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAbyVpy6CQU_U116g&open=AZqHAbyVpy6CQU_U116g&pullRequest=2

Check warning on line 73 in src/strategies/Random.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant jump.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3Rpy6CQU_U117O&open=AZqHAb3Rpy6CQU_U117O&pullRequest=2

Check warning on line 82 in src/backtesting/Operations/Positions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'UpdateSLForSELLDirection' does not access instance data and can be marked as static

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb19py6CQU_U116w&open=AZqHAb19py6CQU_U116w&pullRequest=2

Check warning on line 95 in src/utilities/EnvironmentVariables_v2.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb4mpy6CQU_U1175&open=AZqHAb4mpy6CQU_U1175&pullRequest=2

Check warning on line 43 in src/backtesting/Program.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.Exception' should not be thrown by user code.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb1Xpy6CQU_U116n&open=AZqHAb1Xpy6CQU_U116n&pullRequest=2

Check warning on line 179 in src/backtesting/Ingest/IngestFromQuestDB.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb2ipy6CQU_U1160&open=AZqHAb2ipy6CQU_U1160&pullRequest=2

Check warning on line 244 in src/backtesting/Analysis/Reporting.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s).

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3Gpy6CQU_U117K&open=AZqHAb3Gpy6CQU_U117K&pullRequest=2

Check warning on line 3 in src/Models/BacktestingVariables.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move 'BacktestingLoggingVariables' into a named namespace.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb5Mpy6CQU_U118P&open=AZqHAb5Mpy6CQU_U118P&pullRequest=2

Check warning on line 186 in src/backtesting/Ingest/IngestFromQuestDB.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused local variable 'days'.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb2ipy6CQU_U1165&open=AZqHAb2ipy6CQU_U1165&pullRequest=2

Check warning on line 28 in src/utilities/EnvironmentVariables_v2.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename the enumeration 'BACKTESTING' to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?$'.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb4mpy6CQU_U1178&open=AZqHAb4mpy6CQU_U1178&pullRequest=2

Check warning on line 10 in src/Models/BacktestingVariables.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move 'BacktestingVariables' into a named namespace.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb5Mpy6CQU_U118Q&open=AZqHAb5Mpy6CQU_U118Q&pullRequest=2

Check warning on line 215 in src/backtesting/Analysis/Reporting.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s).

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3Gpy6CQU_U117D&open=AZqHAb3Gpy6CQU_U117D&pullRequest=2

Check warning on line 67 in src/utilities/MedianExtensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use nameof in place of string literal 'source'

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3apy6CQU_U117c&open=AZqHAb3apy6CQU_U117c&pullRequest=2

Check warning on line 19 in src/utilities/MedianExtensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3apy6CQU_U117Y&open=AZqHAb3apy6CQU_U117Y&pullRequest=2

Check warning on line 5 in src/utilities/ReportEnvironmentVariables.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a 'protected' constructor or the 'static' keyword to the class declaration.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3-py6CQU_U117t&open=AZqHAb3-py6CQU_U117t&pullRequest=2

Check warning on line 48 in src/backtesting/Ingest/IngestFromQuestDB.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a format provider when parsing date and time.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb2ipy6CQU_U1161&open=AZqHAb2ipy6CQU_U1161&pullRequest=2

Check warning on line 97 in src/utilities/EnvironmentVariables_v2.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an immutable collection or reduce the accessibility of the public static field 'VariableInjectList'.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb4mpy6CQU_U117_&open=AZqHAb4mpy6CQU_U117_&pullRequest=2

Check warning on line 115 in src/backtesting/Operations/Positions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'IsEmpty' over 'Count' to determine whether the object is empty

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb19py6CQU_U116u&open=AZqHAb19py6CQU_U116u&pullRequest=2

Check warning on line 278 in src/backtesting/Analysis/Reporting.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3Gpy6CQU_U117A&open=AZqHAb3Gpy6CQU_U117A&pullRequest=2

Check warning on line 79 in src/utilities/MedianExtensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb3apy6CQU_U117f&open=AZqHAb3apy6CQU_U117f&pullRequest=2

Check warning on line 57 in src/backtesting/Operations/Positions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'UpdateSLForBUYDirection' does not access instance data and can be marked as static

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb19py6CQU_U116v&open=AZqHAb19py6CQU_U116v&pullRequest=2

Check warning on line 229 in src/backtesting/Ingest/IngestFromQuestDB.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement.

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb2ipy6CQU_U1164&open=AZqHAb2ipy6CQU_U1164&pullRequest=2

Check warning on line 135 in src/utilities/EnvironmentVariables_v2.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'IsEmpty' over 'Count' to determine whether the object is empty

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine&issues=AZqHAb4mpy6CQU_U118I&open=AZqHAb4mpy6CQU_U118I&pullRequest=2