Skip to content

Conversation

@edayot
Copy link
Contributor

@edayot edayot commented Jun 7, 2025

Paired with beet PR

@edayot edayot marked this pull request as ready for review June 7, 2025 19:45
@edayot edayot changed the title feat: full minecraft version is used to get pack_format feat: use full minecraft version to get pack_format #472 Jun 7, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a build script? might be a poetry way to do it. or perhaps we move to uv and try that lol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a build script, i wasn't sure were to put it (maybe in a scripts folder at the repo root).

For the poetry thing it's equivalent of adding a command (like the mecha command in the terminal), and i don't like adding a whole command for just small scripts

@misode misode self-requested a review June 17, 2025 21:07
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really a good idea to include this many large files in the package? I'm not sure how much that really matters realistically.

"1.18", "1.18.1", "1.18.2",
"1.19", "1.19.1", "1.19.2", "1.19.3", "1.19.4",
"1.20", "1.20.1", "1.20.2", "1.20.3", "1.20.4", "1.20.5", "1.20.6",
"1.21", "1.21.1", "1.21.2", "1.21.3", "1.21.4", "1.21.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make this a bit more maintainable...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the system is meant to support multiple patches for different version :

files("mecha.resources").joinpath("patches.json").read_text()

@edayot
Copy link
Contributor Author

edayot commented Jun 19, 2025

Including all file only increase package size, since command tree are parsed when needed :

sources.append(

@Stoupy51

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants