feat: Breadcrumbs for new line diagram page - #3478
Merged
joshlarson merged 4 commits intoSep 8, 2026
Merged
Conversation
…en the route is missing
joshlarson
marked this pull request as ready for review
September 8, 2026 15:04
joshlarson
deleted the
jdl/feat/add-breadcrumbs-to-new-line-diagram-page
branch
September 8, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 💈 Add breadcrumbs to new line diagram page
Implementation
I chose to add an
AssignRoutehook, rather than just querying for the route in theBreadcrumbshook, because I didn't want to create a world where we were re-querying the same route ID over and over again. So the state of the world now is that we have anAssignRoutehook that assigns the route to the socket, and theBreadcrumbshook (if called in the context of the:schedule_page) assumes that:routeis already assigned.Note
🤖 This was mostly human-written, but the commit that adds proper not-found handling was written by Copilot (and then refined with a human touch)
Screenshots
Why yes, I did make sure to get a screenshot where the "Watch Your Step" message had a visible step in it.
How to test
Look at the new line diagram page and see that the breadcrumbs are the same as they are on any of the other tabs.