refactor(ScheduleFinderLive): unique service keys - #3476
Open
thecristen wants to merge 2 commits into
Open
Conversation
Selected service name isn't unique enough to select using Enum.find. Additionally, instead of sending another message, call assign_departures directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🛜 Departures | Service picker changes sometimes don't update page
Implementation
It was occasionally observed that switching the selected service didn't consistently update the displayed Daily Schedules in a timely fashion.
This PR has some tiny changes which will hopefully aid in facilitating a more consistent experience.
Note
I used Copilot to look into the issue and used its findings!
phx-updatefrom the<select>- this should let LiveView actually update theselectedattribute and let the server keep things in sync.How to test
Since this was tricky to observe in the first place, it's also tricky to test! But please play with the service picker and confirm there's no regression there.