[Line Diagram]: Pull timetable parking+accessibility indicators into own component - #3466
Open
lvachon1 wants to merge 2 commits into
Open
[Line Diagram]: Pull timetable parking+accessibility indicators into own component#3466lvachon1 wants to merge 2 commits into
lvachon1 wants to merge 2 commits into
Conversation
…ent. Replaced the duped code with the new component in timetable.ex and new_timetable.ex
smartling-github-connector
Bot
added
the
Not Ready for Translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🛠️💈 Pull timetable parking+accessibility indicators into own component
Implementation
Moved the duplicated A11y and parking icon logic into it's own component. Replaced the duped code with the new component in timetable.ex and new_timetable.ex
Screenshots
New Timetables
Classic Timetables
How to test
http://localhost:4001/schedules/CR-NewBedford/timetable - Confirm that the parking and accessibility icons look and work as expected.