feat: Simplify fares and transfer logic for 2026 fall fares changes - #3463
Draft
joshlarson wants to merge 7 commits into
Draft
feat: Simplify fares and transfer logic for 2026 fall fares changes#3463joshlarson wants to merge 7 commits into
joshlarson wants to merge 7 commits into
Conversation
AI Prompt: Of the tests in transfer_test and fares_test, check to see whether any of them are duplicates of each other, now that the overall logic is simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 💸 🗺️ Update Trip Planner fares to reflect fare pilot starting 9/1
Press Release: Governor Healey Announces New MBTA Affordability Initiatives, Extends Commuter Rail Savings Through Fall
Implementation
Note
🤖 This PR was entirely generated with AI. The first several commits have
(robot)in the prefix - those were AI-generated; the ones withoutThis was the prompt I used for the second commit, which is the meat of the actual work:
Screenshots
Trips from Alewife to Charlestown (Navy Yard)
Trips from Alewife to Orient Heights
How to test
Look at the various trips linked in this PR and in the associated ticket.. Find other ones that involve subway -> subway station-exiting transfers (if you can).
Note
The A/C's also include a mention of reducing express bus fares from $4.25 to $1.70. That was actually accomplished in this PR, which you can validate by looking at this trip in dev where it shows the correct $1.70 fare. It's not reflected in prod yet, because we haven't deployed since ☝️ PR was merged.