Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shuttle): reject shuttles without a route shape #1207

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

rudiejd
Copy link
Contributor

@rudiejd rudiejd commented Apr 4, 2025

Summary of changes

Asana Ticket: [extra] 🏹🐛 Some shuttle definitions are marked as active without required fields

Problem:
You can make a shuttle active without the shuttle having a shape for its route.

Solution:
Prevent users from setting a shuttle to active if its route doesn't have a valid shape

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@rudiejd rudiejd requested a review from a team as a code owner April 4, 2025 19:21
@rudiejd rudiejd requested review from lemald and removed request for a team April 4, 2025 19:21
@rudiejd rudiejd changed the title Fix/reject invalid shuttles fix(shuttle): reject shuttles without a route shape Apr 4, 2025
@rudiejd rudiejd force-pushed the fix/reject-invalid-shuttles branch from 5490d8a to 64904c3 Compare April 7, 2025 13:48
@rudiejd rudiejd force-pushed the fix/reject-invalid-shuttles branch from 64904c3 to 6d64081 Compare April 7, 2025 15:30
@rudiejd rudiejd merged commit cfe1ed5 into master Apr 7, 2025
10 checks passed
@rudiejd rudiejd deleted the fix/reject-invalid-shuttles branch April 7, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants