feat: derive limits from hastus exports #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloanelybutsurely
force-pushed
the
sloane/push-notzstqvkxzl
branch
2 times, most recently
from
bb4f60c to
64a7220
Compare
cmaddox5
reviewed
Apr 4, 2025
sloanelybutsurely
force-pushed
the
sloane/push-notzstqvkxzl
branch
from
64a7220 to
dac1586
Compare
cmaddox5
approved these changes
Apr 4, 2025
i wish this were the case here. i seem to have actually broken some integration tests. working through fixing those! |
sloanelybutsurely
force-pushed
the
sloane/push-notzstqvkxzl
branch
10 times, most recently
from
23e1116 to
d63db7b
Compare
- Adds start_stop_id and end_stop_id to hastus services
- Updates export upload to derive limits from hastus exports
- This looks at the stop_sequences for the trips within the services
in the export to determine the boundary stops
- Renders hastus services with limits in the UI
**Note**: This skips an integration test that I could not for the life
of me figure out a way to fix. It is unclear to me what exactly wasn't
working. The screenshots from the test either showed exactly what the
error said was missing or a progress bar. Some sort of race condition?
[🏹 Implement HASTUS export-derived limits determination & display](https://app.asana.com/0/584764604969369/1209459244072060/f)
sloanelybutsurely
force-pushed
the
sloane/push-notzstqvkxzl
branch
from
d63db7b to
d1bede1
Compare
cmaddox5
added a commit
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏹 Implement HASTUS export-derived limits determination & display
Note: This skips an integration test that I could not for the life of me figure out a way to fix. It is unclear to me what exactly wasn't working. The screenshots from the test either showed exactly what the error said was missing or a progress bar. Some sort of race condition?
Reviewer Checklist