[#2843] Refactor error handling for vragen/aanvragen list views #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
issue/2843-list-views-error-messages
branch
3 times, most recently
from
1b243e3
to
e63a8b1
Compare
- instead of passing silently over errors which occurred when
trying to fetch vragen/aanvragen, we re-raise the exception
and display an informative message to the user
- custom exceptions are introduced for the klanten and zaken
services
pi-sigma
force-pushed
the
issue/2843-list-views-error-messages
branch
from
e63a8b1
to
b6ce4ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1478 +/- ##
===========================================
- Coverage 94.31% 94.29% -0.03%
===========================================
Files 1065 1067 +2
Lines 40001 40027 +26
===========================================
+ Hits 37726 37742 +16
- Misses 2275 2285 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing silently over errors which occurred when trying to fetch vragen/aanvragen, we re-raise the exception and display an informative message to the user.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2843