Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ don't show scopes from notifications.api in the ref page #28

Merged
merged 1 commit into from
May 16, 2024

Conversation

annashamray
Copy link

@annashamray annashamray commented May 10, 2024

Fixes open-zaak/open-notificaties#80 (commonground-api-common part)

Copy link

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin.

It does remove notificaties.publiceren entirely from open-zaak if this was intentional.

@annashamray
Copy link
Author

@Coperh I think it's a good thing. Open Zaak API doesn't provide endpoints with notificaties.publiceren, it uses them itself internally in case Autorisaties API is external. So let's not show them to the client

@annashamray annashamray merged commit a0f5174 into main May 16, 2024
12 checks passed
@annashamray annashamray deleted the issue/duplicated-scopes branch May 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scopes page has duplicate scopes
2 participants