refactor: use typesave utils #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlath
requested changes
Mar 26, 2023
the new syntax works but is transpiled into usable code which is not so easy to read in JS Co-authored-by: maxlath <[email protected]>
maxlath
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two type safe utils to work with JS builtins in a more type safe way.
Also prefer using
Object.entries(ortypedEntries) overObject.keys(obj)with manual access of the valueobj[key]as indexed access could return undefined and TypeScript knows that (with noUncheckedIndexedAccess). Using entries there will contain the value so no need for another check.(Part of #106)