-
Notifications
You must be signed in to change notification settings - Fork 2
Improve Python bindings and Windows&Apple Silicon support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1906615
to
e16f09b
Compare
Build and upload the release binaries for all supported platforms. Also, build and upload Python wheels to PyPI.
maxdoblas
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally aims to improve the initially proposed Python bindings. They were functional but not easy for the final user to use. Thus, we streamlined the Python experience as much as possible, as this feature has been deemed useful for the community. There are still some rough edges, but it is far better.
To that end, we worked on the following features:
pip install .
pip install quicked
.If there is sufficient interest, we will consider working on preparing Conda-forge/Bioconda packages.
To handle this new setup (mainly for precompiled Wheels), we implemented a dynamic dispatcher in the Python module that chooses between the SIMD or scalar compilations depending on host availability.
This process indirectly forced us to add better support for Windows and Apple Silicon machines, as we should support many configurations for the Python package to work on as many machines as possible.
Now, the CMake default config considers the following targets (OS/Arch/Compiler combo):
Unofficially, Android ARM also works, although there is no precompiled package for this target.
As more platforms are now supported, we updated the release Action to upload precompiled binaries for all supported platforms automatically. We also added a release Action to build and upload the Python package to PyPI automatically.