Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sqlx SQLite expiring sessions at wrong time #50

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

kroucher
Copy link
Contributor

@kroucher kroucher commented Sep 9, 2024

Fixes #9

Implemented fix as per suggestion, casting both the column value as well as the comparison value as datetime.

All tests passing, manual tests show the issue reported in #9 is no longer happening (sessions are correctly being removed on time).

Also fixes import locations in documentation to allow for all tests to pass:

-     /// use tower_sessions_sqlx::{sqlx::MySqlPool, MySqlStore};
+     /// use tower_sessions_sqlx_store::{sqlx::MySqlPool, MySqlStore};

@maxcountryman maxcountryman merged commit 6d8bae9 into maxcountryman:main Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlx SQLite expiring sessions at wrong time
2 participants