feat: Handle mosque not found error in API and update mosque manager #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `MosqueFailure` and `MosqueNotFoundFailure` classes to handle specific mosque-related errors. - Updated `Api.dart` to catch Dio 404 errors and throw `MosqueNotFoundFailure`. - Modified `mosque_manager.dart` to handle `MosqueFailure` errors specifically and update state accordingly.
YassinNouh21
force-pushed
the
fix/1159-dioexception-dioexception
branch
from
80a0035
to
f192403
Compare
|
resolve conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR addresses the issue where if the UID of a mosque is not found, the user should be removed or kicked out without an error in the application.
Description
MosqueFailureandMosqueNotFoundFailureclasses to handle specific mosque-related errors.Api.dartto catch Dio 404 errors and throwMosqueNotFoundFailure.mosque_manager.dartto handleMosqueFailureerrors specifically. If aMosqueNotFoundFailureis encountered, the user is removed from the mosque without throwing an error, ensuring a smooth user experience.Tests
🧪 Use case 1
💬 Description:
When attempting to fetch a mosque by UID that does not exist, the application should catch the error, remove the user from the mosque context, and notify listeners without displaying an error message.
📷 Screenshots or GIFs (if applicable):
N/A
Checklist: