Onvif auth #456

joaoantoniocardoso · 2024-11-28T18:36:53Z

Closes Remove Onvif sources not seen for a while #451
Closes Implement Onvif Authentication #452

To be done next:

Add UI
Store credentials in the settings

patrickelectric · 2024-12-10T11:16:29Z

src/lib/controls/onvif/manager.rs

@@ -283,7 +283,7 @@ impl Manager {

        let stream_information = streams_information
            .iter()
-            .find(|&stream_information| &stream_information.stream_uri.to_string() == stream_uri)
+            .find(|&stream_information| stream_information.stream_uri.to_string() == *stream_uri)


I believe that the commit title does not represent the code change

Thanks! I removed the commit since it wasn't necessary.

…UTH environment variable

…ties into a context struct

…ss function

…icit format

…m ManagerContext

…text split

…m URI

joaoantoniocardoso force-pushed the onvif-auth branch 2 times, most recently from 0eeebc3 to 47e5553 Compare November 28, 2024 21:33

joaoantoniocardoso requested a review from patrickelectric November 28, 2024 21:34

joaoantoniocardoso marked this pull request as ready for review November 28, 2024 21:34

joaoantoniocardoso force-pushed the onvif-auth branch 4 times, most recently from e0796db to 40d7a76 Compare November 28, 2024 21:43

joaoantoniocardoso mentioned this pull request Dec 3, 2024

Support Onvif #140

Open

joaoantoniocardoso force-pushed the onvif-auth branch from d9c45ba to 8f72f02 Compare December 9, 2024 20:40

patrickelectric reviewed Dec 10, 2024

View reviewed changes

patrickelectric approved these changes Dec 10, 2024

View reviewed changes

joaoantoniocardoso added 18 commits December 10, 2024 09:00

src: lib: logger: Omit unused error variable

4f96f0e

src: lib: logger: Filter out unwanted logs from 3rd party crates

86388f3

cargo: Enable env clap create feature

11d195d

src: lib: cli: Add onvif-auth CLI arg, with a fallback to MCM_ONVIF_A…

3903086

…UTH environment variable

src: lib: controls: onvif: camera: Split OnvifCamera shareable proper…

ea60de2

…ties into a context struct

src: lib: controls: onvif: camera: Add device_information to context

e9f0222

src: lib: controls: onvif: camera: Implement update_streams_information

a4d0663

src: lib: controls: onvif: camera: Add OnvifDevice to OnvifCamera

9f70406

src: lib: controls: onvif: camera: Instrument get_streams_information

fc480c2

src: lib: controls: onvif: camera: Make get_streams_information a cla…

933671d

…ss function

src: lib: controls: onvif: camera: Add separation spaces, prefet impl…

74eb393

…icit format

src: lib: controls: onvif: camera: Add last_update to OnvifCamera

05706ce

src: lib: video: Add device_information to VideoSourceOnvif

476eddb

src: lib: controls: onvif: manager: Introduce OnvifDevice

31ccfaf

src: lib: controls: onvif: manager: change instrument level to debug

cc5b5f2

src: lib: controls: onvif: manager: Add cdoc for cameras property fro…

9854824

…m ManagerContext

src: lib: controls: onvif: manager: Implement credentials

6186c13

src: lib: controls: onvif: manager: Reimplement onvif discover

4146932

joaoantoniocardoso added 3 commits December 10, 2024 09:01

src: lib: controls: onvif: manager: Update code related to camera con…

3b121a4

…text split

src: lib: server: Add REST endpoints for onvif authentication

c305428

src: lib: controls: onvif: camera: Inject credentials into RTSP strea…

1139567

…m URI

joaoantoniocardoso force-pushed the onvif-auth branch from 8f72f02 to 1139567 Compare December 10, 2024 12:02

joaoantoniocardoso merged commit 3f940bd into mavlink:master Dec 10, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onvif auth #456

Onvif auth #456

joaoantoniocardoso commented Nov 28, 2024 •

edited

Loading

patrickelectric Dec 10, 2024

joaoantoniocardoso Dec 10, 2024

Onvif auth #456

Onvif auth #456

Conversation

joaoantoniocardoso commented Nov 28, 2024 • edited Loading

patrickelectric Dec 10, 2024

Choose a reason for hiding this comment

joaoantoniocardoso Dec 10, 2024

Choose a reason for hiding this comment

joaoantoniocardoso commented Nov 28, 2024 •

edited

Loading