Add h265 support - Part II: Onvif #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoantoniocardoso
changed the title
joaoantoniocardoso
force-pushed
the
add_h265_support_onvif
branch
9 times, most recently
from
f8c54a3 to
85483d9
Compare
joaoantoniocardoso
force-pushed
the
add_h265_support_onvif
branch
2 times, most recently
from
a2402ee to
3270285
Compare
joaoantoniocardoso
force-pushed
the
add_h265_support_onvif
branch
from
3270285 to
c9966b5
Compare
Open
Comment on lines
+67
to
+73
| let _ = mcontext.credentials.insert( | ||
| "192.168.0.168".to_string(), | ||
| Arc::new(RwLock::new(Credentials { | ||
| username: "admin".to_string(), | ||
| password: "12345".to_string(), | ||
| })), | ||
| ); |
There was a problem hiding this comment.
hahaha I think I forgot to implement something here 😆
| debug!(host, "New stream inserted: {stream_information:?}"); | ||
|
|
||
| camera.clone() | ||
| }); | ||
| } |
There was a problem hiding this comment.
TODO: Remove cameras not seen for a while
joaoantoniocardoso
force-pushed
the
add_h265_support_onvif
branch
from
c9966b5 to
edf8d35
Compare
patrickelectric
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, Onvif is now a Video Source, and also a Pipeline, allowing the same API and workflow as for v4l cameras, which means we have all sinks support: UDP/RTSP/Thumbnail/WebRTC.