Fix HTTPS downloads using curl #2460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
f9ed83e to
c8b7537
Compare
…verifypeer" and "followlocation"
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
d3cfea2 to
83050c1
Compare
JonasVautherin
changed the title
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
83050c1 to
2e8929e
Compare
|
@JonasVautherin It works! |
|
Awesome! I just need to fix the iOS/macOS build with the updated gRPC now! |
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
e81ff8b to
93e0d54
Compare
Merged
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
93e0d54 to
7f76824
Compare
|
Hmm with the latest version of gRPC I had to update protobuf, which means that I need to re-generate the code... I don't know how I feel about that. Trying with an older version of gRPC, see if that works. The PR for v3 does update protobuf, though: #2460 |
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
7f76824 to
9b90fc5
Compare
This is because openssl3 does not support the system certificates on Android and does not seem to plan to support them.
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
9b90fc5 to
0ba884c
Compare
JonasVautherin
force-pushed
the
v2-curl-https-android-try-boringssl
branch
from
0ba884c to
7305fa1
Compare
|
|
Closing this as I opted for simple hack for v2: #2471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves mavlink/MAVSDK-Java#192.
In a previous PR, we have built curl with ssl support. But that is not enough for Android. First, curl does not auto-detect the system certificates on Android (at least not on all versions of Android). Second, OpenSSL3 cannot parse the Android system certificates (again at least on the versions of Android we tested) and it does not seem like this will change. BoringSSL, on the other hand, works with the Android system certificates.
I don't think that we should move MAVSDK entirely to BoringSSL for different reasons, one of them being that the default ssl library on many systems is OpenSSL. However, if OpenSSL3 does not really support Android, it seems like it makes sense to move to BoringSSL. Just for Android.
@julianoes: In order for boringssl to build, I had to update grpc, which in turn forced me to update protobuf, and hence to regenerate the code 🙈
@rayw-dronesense: would you mind testing this on your setup? 🙏