WIP: unify handleBotInvite and GetManagementRoom setup logic#524
Draft
JJTech0130 wants to merge 1 commit into
Draft
WIP: unify handleBotInvite and GetManagementRoom setup logic#524JJTech0130 wants to merge 1 commit into
JJTech0130 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are two separate paths for the bridge bot being invited to a room, vs. a room that is automatically created by calling
GetManagementRoom.This PR unifies the logic which assigns the room name, topic, and avatar. Additionally, it adds an
m.bridgeevent with the newcom.beeper.is_bridge_bot_roomkey, which is currently injected by Hungryserv automatically.I think there might be a third case to think about, rooms which were not previously management rooms promoted using the
set-management-roomcommand.