Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to changes in mautic/mautic#12813 #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Feb 18, 2024

In mautic/mautic#12813 some logic changed, and it is now required to pass the PostAction in the payload of form API calls.

IMO this is a breaking change, and the default on the Mautic should change to something that is compatible with the previous flow.

If we want to change that default, it needs to be done in M6.
This PR is purely meant to show where the issue with the tests is located, not to be merged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa141f9) 52.49% compared to head (5ece05d) 52.49%.

❗ Current head 5ece05d differs from pull request most recent head 404da02. Consider uploading reports for the commit 404da02 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #320   +/-   ##
=========================================
  Coverage     52.49%   52.49%           
  Complexity      390      390           
=========================================
  Files            30       30           
  Lines          1042     1042           
=========================================
  Hits            547      547           
  Misses          495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍
Thank you.

@mollux
Copy link
Contributor Author

mollux commented Feb 19, 2024

@kuzmany it shouldn't look good, see the description :) this should be addressed in mautic/mautic, so this change isn't needed

@kuzmany
Copy link
Member

kuzmany commented Feb 19, 2024

Ah, okay I have to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants