Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setLogger with built in trait #315

Closed
wants to merge 1 commit into from

Conversation

moorl
Copy link

@moorl moorl commented Oct 19, 2023

For my mautic API integration I can't use repositories in composer.

I Found a better way for backwards compatibility. Just use the built-in trait.

Kind regards
moori

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #315 (7f8d623) into main (fa141f9) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 7f8d623 differs from pull request most recent head 0578aff. Consider uploading reports for the commit 0578aff to get more accurate results

@@             Coverage Diff              @@
##               main     #315      +/-   ##
============================================
+ Coverage     52.49%   52.59%   +0.10%     
+ Complexity      390      389       -1     
============================================
  Files            30       30              
  Lines          1042     1040       -2     
============================================
  Hits            547      547              
+ Misses          495      493       -2     
Files Coverage Δ
lib/Api/Api.php 81.20% <ø> (+1.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RCheesley RCheesley closed this Jul 18, 2024
@RCheesley RCheesley reopened this Jul 18, 2024
@RCheesley
Copy link
Sponsor Member

Hi @moorl could you possibly fix the codestyle issue causing the tests to fail? Thanks!

@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
@escopecz
Copy link
Sponsor Member

Fixed in #327

@escopecz escopecz closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants