Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CitrixPlugin from tests #304

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

mabumusa1
Copy link
Member

No description provided.

@mabumusa1 mabumusa1 added the Bug label May 30, 2023
@mabumusa1 mabumusa1 requested a review from escopecz May 30, 2023 10:29
@mabumusa1 mabumusa1 self-assigned this May 30, 2023
@mollux
Copy link
Contributor

mollux commented May 30, 2023

@mabumusa1 we can't do this like this. We need a separate major release, as this behavior is different between 4 and 5

@mabumusa1
Copy link
Member Author

@mabumusa1 we can't do this like this. We need a separate major release, as this behavior is different between 4 and 5

@mollux Good point, how do you suggest we do it, since we do not have separate branches

@codecov-commenter
Copy link

Codecov Report

Merging #304 (d94231f) into main (28190cb) will not change coverage.
The diff coverage is n/a.

❗ Current head d94231f differs from pull request most recent head 08556a8. Consider uploading reports for the commit 08556a8 to get more accurate results

@@            Coverage Diff            @@
##               main     #304   +/-   ##
=========================================
  Coverage     51.96%   51.96%           
  Complexity      407      407           
=========================================
  Files            30       30           
  Lines          1093     1093           
=========================================
  Hits            568      568           
  Misses          525      525           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@escopecz
Copy link
Member

I think we can merge this and release it together with M5 as a new major release. There are other PRs with BC changes that we should get in.

@mollux mollux merged commit 8d9da8b into main Jun 16, 2023
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants