Enable basic PHPSTAN checks #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
added
the
chore
|
@dennisameling do you need me to test this or is it just a case of getting the green tick to merge? 🤓 ✅ |
escopecz
requested changes
Feb 27, 2021
| @@ -471,7 +471,7 @@ public function testCampaignContactEditEvent() | |||
| $date = new \DateTime($log['triggerDate'], new \DateTimeZone('UTC')); | |||
| $this->assertEquals($log['triggerDate'], $date->format('c')); | |||
| } else { | |||
| $this->assertFalse(false, 'Event ID not recognized in the log.', var_export($event, true)); | |||
| $this->assertFalse(var_export($event, true), 'Event ID not recognized in the log.'); | |||
There was a problem hiding this comment.
This doesn't make much sense. The previous version did not make sense either. I expect the intent was to fail the test if this assert will run. How about this:
Suggested change
| $this->assertFalse(var_export($event, true), 'Event ID not recognized in the log.'); | |
| $this->fail('Event ID not recognized in the log.'.var_export($event, true)); |
This was referenced Mar 24, 2023
53 tasks
54 tasks
|
@escopecz some conflicts with this PR - suggest that we have someone from @mautic/core-team pick this up if we want to merge it? |
|
Yep, it'd be great to get this sorted |
|
Closing in favour of #325 - thanks for the efforts folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up basic PHPSTAN checks. Setting the level higher than 1 causes quite some errors/warnings, so I'm leaving it at 1 for now.