-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SmartAsserts.jl #152
Conversation
Thanks! Comments:
x-ref: #120 |
I decided not to use ArgCheck as it's ability to compile out asserts is not supported on new versions of julia, OptionalArgChecks.jl is broken on >= 1.5. I've updated the tests, thanks for spotting that. The main problem now is I didn't notice SmartAssert has set its compat to julia 1.5, I'll see if I can get that changed. |
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 93.42% 93.75% +0.32%
==========================================
Files 1 1
Lines 304 304
==========================================
+ Hits 284 285 +1
+ Misses 20 19 -1
|
This should be ready to be merged in now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests! There are still a few bits to do. Also, let's move the compat for Julia to 1.5.
Sorry, one more thing: now we just need some docs! Nothing fancy, just add to where |
Thanks so much for your help! |
It should be easy to add any other similar package such as ArgChecks.jl