Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up the MoveUp and MoveDown functions #45

Merged
merged 6 commits into from
Jul 5, 2020
Merged

Cleaning up the MoveUp and MoveDown functions #45

merged 6 commits into from
Jul 5, 2020

Conversation

hugomg
Copy link
Contributor

@hugomg hugomg commented Jul 5, 2020 •
edited
Loading

This PR cleans up the code for moving things up and down, getting rid of some code duplication. Some of these ideas are from PR #27.

  1. Replace pairs of MoveUp and MoveDown functions by a single MoveVertically function.
  2. Don't treat the movement near the edge of the file as a special case -- a single call to min() or max() is all we need.
  3. Get rid of the separate functions for moving things up and down by half a page.
  4. Allow setting g:move_auto_indent to values other than 0 or 1

hugomg added 6 commits July 4, 2020 12:42
@hugomg
Remove some dead code
37cbd8b 
The calls to min() and max() ensure that these conditions are never
true.
@hugomg
Consolidate ModeLineUp and MoveLineDown
c7f35c4 
Reduce code duplication by replacing MoveLineUp and MoveLineDown by a
single function, MoveLineVertically.
@hugomg
Consolidate MoveBlockUp and MoveBlockDown
1fcb8cf 
Reduce code duplication by replacing MoveBlockUp and MoveBlockDown by a
single function, MoveBlockVertically.
@hugomg
Consolidate the HalfPage functions
2067ce0 
Reduce code duplication by putting the computation of half page size in
a separate function.
@hugomg
Test truthyness of g:move_auto_indent
82001af 
People might expect that any truthy value should work to enable auto
indent, and not just 1.
@hugomg
Get rid of the MoveRange function
741a643
@matze
Copy link
Owner

matze commented Jul 5, 2020

Looks good, less code is always better 👍

@matze matze merged commit 0745906 into matze:master Jul 5, 2020
@hugomg hugomg mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomg @matze