Preserve ordering of object properties #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
(BTW, the actual change to the implementation is minimal. Most of that 1k diff is from 120d385, which just wraps the existing tests in a test suite) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the JSON spec (emphasis added).
And yet... humans sure seem to ascribe a lot significance to the order of properties in a JSON schema.
Say you're auto-generating form UI for a
createEventtool that takes astartandend. If you use lexicographic ordering, you'll be asking users to start with the end in mind.Balderdash!, I say.
This PR updates
.objectto store properties as anOrderedDictionary<String, JSONSchema>. Yes, this adds a new external dependency on swift-collections, but I don't think that's too onerous. The juice seems worth the squeeze, IMO.