Bump minimum Swift Collections version to 1.1.0 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public type `JSONSchema` depends on `OrderedDictionary` from the swift-collections package, and the `Sendable` conformance of `JSONSchema` requires that `OrderedDictionary` also be `Sendable`. The `OrderedDictionary` only gained `Sendable` conformance in version 1.1.0[^1], so we need to require at least that version. [^1: apple/swift-collections@17b6c8f
mattt
approved these changes
Aug 28, 2025
Owner
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
Thanks so much for this, Saito-san!
Owner
|
This change is now live in 1.3.1 |
Contributor
Author
|
Thank you for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public type
JSONSchemadepends onOrderedDictionaryfrom the swift-collections package, and theSendableconformance ofJSONSchemarequires thatOrderedDictionaryalso beSendable.The
OrderedDictionaryonly gainedSendableconformance in version 1.1.01, so we need to require at least that version.Footnotes
https://github.com/apple/swift-collections/commit/17b6c8f5c79b28595cbd6efb9719582ea4ab240e ↩