Fix testFullAPIIntegration flakiness
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flakiness in the testFullAPIIntegration test by replacing a withCheckedContinuation approach with a timeout-based task group implementation.
- Replaces continuation-based async handling with
withThrowingTaskGroup - Adds explicit timeout handling with a 5-second limit
- Implements completion monitoring with polling mechanism
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mattt
force-pushed
the
mattt/fix-test-flake
branch
from
d522eee to
40de096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.