Skip to content

return non-nil result when calling exec with empty query#973

Merged
mattn merged 1 commit intomattn:masterfrom
cyolosecurity:exec_empty_query
Oct 19, 2021
Merged

return non-nil result when calling exec with empty query#973
mattn merged 1 commit intomattn:masterfrom
cyolosecurity:exec_empty_query

Conversation

@avivklas
Copy link
Copy Markdown
Contributor

@avivklas avivklas commented Oct 19, 2021 •
edited
Loading

Proposed changes

  • fixed exec to always return driver.Result even when there's nothing to actually run
  • added test for calling exec with empty statement

fixes #963

@mattn
Copy link
Copy Markdown
Owner

mattn commented Oct 19, 2021

LGTM

@mattn mattn merged commit 3900dc3 into mattn:master Oct 19, 2021
@mattn
Copy link
Copy Markdown
Owner

mattn commented Oct 19, 2021

Thank you

@avivklas avivklas deleted the exec_empty_query branch February 28, 2023 11:06
@ganigeorgiev ganigeorgiev mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is this a bug in the database/sql layer? Panic on Exec of empty string

2 participants

@avivklas @mattn