Update phpunit/phpunit from 8.3.4 to 8.5.43 #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe version requirement for the "phpunit/phpunit" development dependency in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "squizlabs/php_codesniffer": "3.*", | ||
| "phpmd/phpmd": "@stable", | ||
| "phpunit/phpunit": "8.3.4", | ||
| "phpunit/phpunit": "8.5.43", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Prefer a non-pinned constraint and verify PHP/CI compatibility
- Pinned "8.5.43" blocks future 8.5.x patches. Consider "^8.5" (or "8.5.*") to receive bug/security fixes automatically.
- PHPUnit 8.5 requires PHP >= 7.2. If your CI or local dev uses PHP 7.1.x, installs/tests will fail. Consider declaring the PHP requirement to make this explicit.
Apply this inline change:
- "phpunit/phpunit": "8.5.43",
+ "phpunit/phpunit": "^8.5",Optionally, make the PHP runtime requirement explicit (outside the changed line range):
{
"require": {
"php": ">=7.2",
"guzzlehttp/guzzle": "6.3.*",
"symfony/dotenv": "4.3.*",
"ext-json": "*"
}
}Run this script to confirm constraints and CI PHP versions:
🏁 Script executed:
#!/bin/bash
set -e
echo "composer.json PHP requirement:"
jq -r '.require.php // "(none declared)"' composer.json
echo "composer.json PHPUnit constraint:"
jq -r '.["require-dev"]["phpunit/phpunit"]' composer.json
if [ -f composer.lock ]; then
echo "composer.lock PHPUnit resolved version:"
jq -r '.["packages-dev"][]? | select(.name=="phpunit/phpunit") | .version' composer.lock
else
echo "composer.lock not found (skipping lock verification)"
fi
echo ""
echo "Searching CI configs for PHP versions…"
for f in ".travis.yml" "azure-pipelines.yml" "circle.yml" "appveyor.yml"; do
if fd -H -a -t f -p "$f" >/dev/null 2>&1; then
fd -H -a -t f -p "$f" | while read -r file; do
echo "--- $file ---"
sed -n '1,200p' "$file" | sed 's/^/ /'
done
fi
done
if fd -H -a -t f -p ".github/workflows" >/dev/null 2>&1; then
fd -H -a -t f -p ".github/workflows" | while read -r wf; do
echo "--- $wf ---"
sed -n '1,200p' "$wf" | sed 's/^/ /'
done
fiLength of output: 2153
Composer: Loosen PHPUnit constraint and declare PHP requirement
- Loosen the pinned PHPUnit version so you receive future 8.5.x patches:
- "phpunit/phpunit": "8.5.43",
+ "phpunit/phpunit": "^8.5",- Explicitly declare your PHP runtime baseline (PHPUnit 8.5 needs PHP ≥ 7.2; your Travis CI runs 7.2 & 7.3):
{
"require": {
- // no PHP version declared
+ "php": ">=7.2",
"guzzlehttp/guzzle": "6.3.*",
"symfony/dotenv": "4.3.*",
"ext-json": "*"
}
}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In composer.json at line 23, the PHPUnit version is strictly pinned to 8.5.43,
which limits receiving future patch updates. Loosen the PHPUnit version
constraint to allow any 8.5.x version by changing it to "8.5.*". Additionally,
explicitly declare the PHP version requirement in the composer.json "require"
section to specify the minimum PHP version as 7.2, matching the PHPUnit 8.5
requirement and your CI environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a high test coverage index, and your tests for this pull request are passing, it should be both safe and recommended to merge this update.
Updated packages
Some times an update also needs new or updated dependencies to be installed. Even if this branch is for updating one dependency, it might contain other installs or updates. All of the updates in this branch can be found here:
Working with this branch
If you find you need to update the codebase to be able to merge this branch (for example update some tests or rebuild some assets), please note that violinist will force push to this branch to keep it up to date. This means you should not work on this branch directly, since you might lose your work. Read more about branches created by violinist.io here.
This is an automated pull request from Violinist: Continuously and automatically monitor and update your composer dependencies. Have ideas on how to improve this message? All violinist messages are open-source, and can be improved here.
Summary by CodeRabbit