Skip to content

Commit

Permalink
Tidy up and remove unused things (#464)
Browse files Browse the repository at this point in the history 
- The Docker stuff had broken and with no tests/uncertain uses
  I decided to remove it. We can resurrect if useful (cc @pacman-ghost)
- Delete some unused icons
- Fix up the prettier ignore
  • Loading branch information
@mattgodbolt
mattgodbolt authored Dec 31, 2024
1 parent 0e8954a commit 038f5ad
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 112 deletions.
2 changes: 1 addition & 1 deletion .prettierignore
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
out
dist
tests/6502_65C02_functional_tests
tests/integration/dp111_6502Timing
package-lock.json
19 changes: 0 additions & 19 deletions Dockerfile
View file

This file was deleted.

Binary file removed build/icon.ico
View file
Binary file not shown.
Binary file removed build/icon.png
View file
Binary file not shown.
92 changes: 0 additions & 92 deletions run-container.sh
View file

This file was deleted.

1 comment on commit 038f5ad

@pacman-ghost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the late response, I've been flat out the past few months, but I've finally had a chance to look into this.

The build broke because you updated to Node 20, and this needs to be reflected in the Dockerfile. And the distributable output is now in a new place.

with no tests/uncertain uses

I'm usually pretty religious about tests :-), but it's a bit pointless, in this case.

WRT use cases, if you don't know already, Docker is a way of packaging up applications. Normally, to run jsbeeb, you would have to set up npm, any other dependencies, configure a bunch of stuff. This has to be done on every computer you want to run on, and opens the door for conflicts with any other stuff you might have installed.

Docker gives you a one-step, automated, reproducible way to run an application, and it runs in a sandbox. Just do a docker build once to set things up, then docker run to run it, and everything happens automagically, and isolated from everything else. run-container.sh provides a wrapper around this, with a nicer interface.

Furthermore, I have 7 or 8 applications I run in my home lab, all Docker'ized in a K8s cluster, which makes managing them very easy.

If you don't want to have this, that's cool, but let me know if you want to add it back, and I'll send you a PR.

BTW, if you want to remove this stuff completely, docker/nginx-default.conf also needs to go.

Please sign in to comment.